On Wed, Sep 25, 2024 at 11:01 PM Bertrand Drouvot <bertranddrouvot...@gmail.com> wrote: > > Hi, > > On Wed, Sep 25, 2024 at 11:23:17AM +0530, shveta malik wrote: > > + OUT catchange_xip xid[] > > > > One question, what is xid datatype, is it too int8? Sorry, could not > > find the correct doc. > > I think that we can get the answer from pg_type: > > postgres=# select typname,typlen from pg_type where typname = 'xid'; > typname | typlen > ---------+-------- > xid | 4 > (1 row) > > > Since we are getting uint32 in Int64, this also needs to be accordingly. > > I think the way it is currently done is fine: we're dealing with TransactionId > (and not with FullTransactionId). So, the Int64GetDatum() output would still > stay in the "xid" range. Keeping xid in the .sql makes it clear that we are > dealing with transaction ID. >
Okay, got it. The 'xid' usage is fine then. thanks Shveta
