Nathan Bossart <nathandboss...@gmail.com> writes:
> I think we should use INT64_FORMAT here. That'll choose the right length
> modifier for the platform. And I don't think we need to cast MyStartTime,
> since it's a pg_time_t (which is just an int64).
Agreed. However, a quick grep finds half a dozen other places that
are casting MyStartTime to long. We should fix them all.
Also note that if any of the other places are using translatable
format strings, INT64_FORMAT is problematic in that context, and
"long long" is a better answer for them.
(I've not dug in the history, but I rather imagine that this is all
a hangover from MyStartTime having once been plain "time_t".)
regards, tom lane
