On Thu, Sep 19, 2024 at 10:03:09AM +0200, Alvaro Herrera wrote: > It looks to me like these cases could be modified to accept only > ATT_PARTITIONED_TABLE, not ATT_TABLE anymore. The ATT_TABLE cases are > useless anyway, because they're rejected by transformPartitionCmd.
Makes sense to me, thanks for the suggestion. What do you think about adding a test with DETACH FINALIZE when attempting it on a normal table, its path being under a different subcommand than DETACH [CONCURRENTLY]? There are no tests for normal tables with DETACH CONCURRENTLY, but as it is the same as DETACH under the AT_DetachPartition subcommand, that does not seem worth the extra cycles. -- Michael
signature.asc
Description: PGP signature
