On Tue, Sep 10, 2024 at 2:16 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Tue, Sep 10, 2024 at 11:36 AM vignesh C <vignes...@gmail.com> wrote: > > > > On Mon, 9 Sept 2024 at 13:12, Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > > > The second part of the assertion is incomplete. The > > > IsIndexUsableForReplicaIdentityFull() should be used only when the > > > remote relation has REPLICA_IDENTITY_FULL set. I haven't tested all > > > possible cases yet but I think the attached should be a better way to > > > write this assertion. > > > > The changes look good to me. > > > > Thanks, I'll push this tomorrow unless Dilip or anyone else has any > comments. BTW, as the current code doesn't lead to any bug or > assertion failure, I am planning to push this change to HEAD only, let > me know if you think otherwise. >
Pushed. -- With Regards, Amit Kapila.
