On Wed, Sep 4, 2024 at 6:42 PM Alena Rybakina <a.rybak...@postgrespro.ru> wrote: > On 04.09.2024 18:31, Alena Rybakina wrote: > > I rewrote the tests with integer types. Thanks for your suggestion. If > > you don't mind, I've updated the diff file you attached earlier to > > include the tests. > Sorry, I've just noticed that one of your changes with the regression > test wasn't included. I fixed it here.
Please, find the revised patchset attached. I've integrated the fixes by you and Andrei in the thread. Also, I've addressed the note from Andrei [1] about construction of RestrictInfos. I decided to use make_simple_restrictinfo() in match_orclause_to_indexcol(), because I've seen its usage in get_index_clause_from_support(). Also, I agree it get it's wrong to directly copy RestrictInfo struct in group_similar_or_args(). Instead, I've renamed make_restrictinfo_internal() to make_plain_restrictinfo(), which is intended to handle non-recursive cases when you've children already wrapped with RestrictInfos. make_plain_restrictinfo() now used in group_similar_or_args(). Hopefully, this item is resolved by now. Links. 1. https://www.postgresql.org/message-id/60760203-4917-4c6c-ac74-a5ee764735a4%40gmail.com ------ Regards, Alexander Korotkov
v39-0002-Teach-bitmap-path-generation-about-transforming-.patch
Description: Binary data
v39-0001-Transform-OR-clauses-to-SAOP-s-during-index-matc.patch
Description: Binary data
