Hi hackers, While working on the per backend I/O statistics patch ([1]), I noticed that there is an unnecessary call to TimestampTzGetDatum() in pg_stat_get_io() ( as the reset_time is already a Datum).
Please find attached a tiny patch to remove this unnecessary call. [1]: https://www.postgresql.org/message-id/flat/ZtXR%2BCtkEVVE/LHF%40ip-10-97-1-34.eu-west-3.compute.internal Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
>From 09f7815a1dfe066ee3652b4f962b3f575aeee88e Mon Sep 17 00:00:00 2001 From: Bertrand Drouvot <bertranddrouvot...@gmail.com> Date: Fri, 6 Sep 2024 08:47:37 +0000 Subject: [PATCH v1] Remove one TimestampTzGetDatum call in pg_stat_get_io() When setting the tuple's value in pg_stat_get_io() there is no need to call TimestampTzGetDatum() as reset_time is already a Datum. --- src/backend/utils/adt/pgstatfuncs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) 100.0% src/backend/utils/adt/ diff --git a/src/backend/utils/adt/pgstatfuncs.c b/src/backend/utils/adt/pgstatfuncs.c index 97dc09ac0d..33c7b25560 100644 --- a/src/backend/utils/adt/pgstatfuncs.c +++ b/src/backend/utils/adt/pgstatfuncs.c @@ -1408,7 +1408,7 @@ pg_stat_get_io(PG_FUNCTION_ARGS) values[IO_COL_BACKEND_TYPE] = bktype_desc; values[IO_COL_CONTEXT] = CStringGetTextDatum(context_name); values[IO_COL_OBJECT] = CStringGetTextDatum(obj_name); - values[IO_COL_RESET_TIME] = TimestampTzGetDatum(reset_time); + values[IO_COL_RESET_TIME] = reset_time; /* * Hard-code this to the value of BLCKSZ for now. Future -- 2.34.1
