On Wed, Aug 28, 2024 at 5:26 PM Ashutosh Bapat <ashutosh.bapat....@gmail.com> wrote: > > On Fri, Aug 23, 2024 at 9:55 PM Jacob Champion > <jacob.champ...@enterprisedb.com> wrote: > > > > On Fri, Aug 23, 2024 at 5:59 AM Ashutosh Bapat > > <ashutosh.bapat....@gmail.com> wrote: > > > If I run > > > export PG_TEST_EXTRA=xid_wraparound; ./configure --prefix=$BuildDir > > > --enable-tap-tests && make -j4 && make -j4 install; unset > > > PG_TEST_EXTRA > > > followed by > > > make -C $XID_MODULE_DIR check where > > > XID_MODULE_DIR=src/test/modules/xid_wraparound - it skips the tests. > > > > Right. > > > > > I thought this was working before. > > > > No, that goes back to my note in [1] -- as of c3382a3c3cc, the > > variable was exported at only the src/test level, and I wanted to get > > input on that so we could decide on the next approach if needed.
I had an offline discussion with Jacob. Because of c3382a3c3cc, `make -C src/test/modules/xid_wraparound check` will skip xid_wraparound tests. It should be noted that when that commit was added well before the xid_wraparound tests were added. But I don't know whether the tests controlled by PG_TEST_EXTRA could be run using make -C that time. Anyway, I think, supporting PG_TEST_EXTRA at configure time without being able to run tests using `make -C <test directory> ` is not that useful. It only helps make check-world but not when running individual tests. Nazir, since you authored c3382a3c3cc, can you please provide input that Jacob needs? Otherwise, we should just go ahead with meson support and drop make support for now. We may revisit it later. -- Best Wishes, Ashutosh Bapat
