On Wed, 28 Aug 2024 at 09:52, Tom Lane <t...@sss.pgh.pa.us> wrote: > The other problem with this is that it breaks one test case in > memoize.sql: a query that formerly generated a memoize plan > now does not use memoize. I am not sure why not --- does that > mean anything to you?
The reason it works in master is that get_memoize_path() calls extract_lateral_vars_from_PHVs() and finds PlaceHolderVars to use as the Memoize keys. With your patch PlannerInfo.placeholder_list is empty. The commit that made this work is 069d0ff02. Richard might be able to explain better. I don't quite understand why RelOptInfo.lateral_vars don't contain these in the first place. David