On Sat, Aug 24, 2024 at 9:47 PM Peter Eisentraut <pe...@eisentraut.org> wrote: > > On 24.08.24 14:49, Junwang Zhao wrote: > > What I haven't addressed is that the repo still uses specific local > > paths, I think > > this is ok since the code is not going into the core. > > I'm not among the target users of this, but I imagine that that would > significantly reduce the utility of this for everyone besides you?
Yeah, the reason why I started this thread is that we(at least Jelta and I) think it may make some potential new contributors' lives easier. > > > One thing I want to ask is, is there any objection to adding the > > .devcontainer and .vscode to the .gitignore file? > > The standing policy is that files related to IDEs and editors should not > be in our .gitignore, but you can put them into your personal ignore > file somewhere. Sure, I can put them in global ignore file in various ways. I just saw the policy in the comment, so I'm ok with it. > > > There are *.vcproj and pgsql.sln in .gitignore, so I guess it's ok to add > > .devcontainer and .vscode? > > Those are files generated by the build process, so it is appropriate to > have them there. But in fact, they should have been removed now that > the MSVC build system is done. > -- Regards Junwang Zhao
