Thanks for the feedback Melih, On Thu, 22 Aug 2024 at 21:26, Melih Mutlu <m.melihmu...@gmail.com> wrote: > It seems like extended_relation_expr allows "tablename *" syntax too. That > should be added in docs as well. (Same for VACUUM doc)
I had included it in the parameter description but had missed it from the synopsis. I've fixed that now. > We may also want to update the above note in ANALYZE doc. Well spotted. I have updated that now. > Tests don't seem right to me. > I believe the above should be " PARTITION OF only_parted " instead of > vacparted. > It may better to insert into partitioned table (only_parted) instead of the > partition (only_parted1); > > Also it may be a good idea to test VACUUM ONLY for inheritance tables the > same way you test ANALYZE ONLY. Well spotted again. I have fixed the incorrect table names and added tests as suggested. > Lastly, the patch includes an unrelated file (compile_flags.txt) and has > whitespace errors when I apply it. Oops! Fixed, V2 of the patch is attached. Cheers Mike
v2-0001-Initial-implementation-of-the-ONLY-feature.patch
Description: Binary data
