On Mon, Aug 19, 2024 at 11:01 AM Peter Smith <smithpb2...@gmail.com> wrote: > > Hi, Here are my review comments for v27-0001. > > ====== > contrib/test_decoding/expected/generated_columns.out > contrib/test_decoding/sql/generated_columns.sql > > +-- By default, 'include-generated-columns' is enabled, so the values > for the generated column 'b' will be replicated even if it is not > explicitly specified. > > nit - The "default" is only like this for "test_decoding" (e.g., the > CREATE SUBSCRIPTION option is the opposite), so let's make the comment > clearer about that. > nit - Use sentence case in the comments.
I have addressed all the comments in the v-28-0001 Patch. Please refer to the updated v28-0001 Patch here in [1]. See [1] for the changes added. [1] https://www.postgresql.org/message-id/CAHv8RjL7rkxk6qSroRPg5ZARWMdK2Nd4-QyYNeoc2vhBm3cdDg%40mail.gmail.com Thanks and Regards, Shubham Khanna.
