On Wed, Aug 21, 2024 at 3:04 PM Zhijie Hou (Fujitsu) <houzj.f...@fujitsu.com> wrote: > > > Attach the V20 patch set which addressed above, Shveta[1][2] and > Kuroda-san's[3] > comments. >
Thank You for the patch. Few comments: 1) + The key section includes the key values of the local tuple that violated a unique constraint insert_exists or update_exists conflicts. --I think something is missing in this line. Maybe add a 'for' or *in case of*: The key section includes the key values of the local tuple that violated a unique constraint *in case of*/*for* insert_exists or update_exists conflicts. 2) + The replica identity section includes the replica identity key values that used to search for the existing local tuple to be updated or deleted. --that *were* used to thanks Shveta