On Tue, Aug 20, 2024 at 08:13:12PM -0400, Alvaro Herrera wrote: > I don't understand what do the inj_stats_enabled stuff have to do with > this patch. I suspect it's a git operation error, ie., you seem to have > squashed two different things together.
Sorry, I should have split that for clarity (one patch for the GUC, one to change the test to use CACHED/LOAD). It is not an error though: if we don't have a controlled way to disable the stats of the module, then the test would fail when calling the cached callback because we'd try to allocate some memory for the dshash entry in pgstats. The second effect of initializing the shmem state of the module with shared_preload_libraries is condition variables are set up for the sake if the test, removing the dependency to the SQL load() call. Both are OK, but I'd prefer introducing one use case for these two macros in the tree, so as these can be used as a reference in the future when developing new tests. -- Michael
signature.asc
Description: PGP signature
