On 2024-08-19 Mo 8:00 AM, Alexander Lakhin wrote:
Hello Andrew,
29.07.2024 13:54, Andrew Dunstan wrote:
On 2024-07-29 Mo 4:00 AM, Alexander Lakhin wrote:
And another interesting fact is that TEMP_CONFIG is apparently
ignored by
`meson test regress/regress`. For example, with temp.config containing
invalid settings, `meson test pg_upgrade/002_pg_upgrade` fails, but
`meson test regress/regress` passes just fine.
Well, that last fact explains the discrepancy I originally complained
about. How the heck did that happen? It looks like we just ignored
its use in Makefile.global.in :-(
Please look at the attached patch (partially based on ideas from [1]) for
meson.build, that aligns it with `make` in regard to use of TEMP_CONFIG.
Maybe it could be implemented via a separate meson option, but that would
also require modifying at least the buildfarm client...
[1]
https://www.postgresql.org/message-id/CAN55FZ304Kp%2B510-iU5-Nx6hh32ny9jgGn%2BOB5uqPExEMK1gQQ%40mail.gmail.com
I think this is the way to go. The patch LGTM.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
