On Wed, Aug 14, 2024 at 10:26 AM shveta malik <shveta.ma...@gmail.com> wrote: > > > > > Thanks for the detailed analysis. I agree with your analysis that we > > need to reset the origin information for the shutdown path to avoid it > > being advanced incorrectly. However, the patch doesn't have sufficient > > comments to explain why we need to reset it for both the ERROR and > > Shutdown paths. Can we improve the comments in the patch? > > > > Also, for the ERROR path, can we reset the origin information in > > apply_error_callback()? > > Please find v4 attached. Addressed comments in that. >
The patch looks mostly good to me. I have slightly changed a few of the comments in the attached. What do you think of the attached? -- With Regards, Amit Kapila.
v5-0001-Don-t-advance-origin-during-apply-failure.patch
Description: Binary data
