Hi all, While hacking on a different thing, I've noticed that ldap_password_func had the idea to define _PG_fini(). This is pointless, as library unloading is not supported in the backend, and something that has been cleaned up from the tree in ab02d702ef08. That's not something to encourage, perhaps, as well..
How about removing it like in the attached to be consistent? Thanks, -- Michael
diff --git a/src/test/modules/ldap_password_func/ldap_password_func.c b/src/test/modules/ldap_password_func/ldap_password_func.c
index 99c18a8f1c..24d9c63781 100644
--- a/src/test/modules/ldap_password_func/ldap_password_func.c
+++ b/src/test/modules/ldap_password_func/ldap_password_func.c
@@ -23,7 +23,6 @@
PG_MODULE_MAGIC;
void _PG_init(void);
-void _PG_fini(void);
/* hook function */
static char *rot13_passphrase(char *password);
@@ -37,12 +36,6 @@ _PG_init(void)
ldap_password_hook = rot13_passphrase;
}
-void
-_PG_fini(void)
-{
- /* do nothing yet */
-}
-
static char *
rot13_passphrase(char *pw)
{
signature.asc
Description: PGP signature
