On Mon, Aug 19, 2024 at 3:03 PM shveta malik <shveta.ma...@gmail.com> wrote: > > On Mon, Aug 19, 2024 at 12:32 PM Zhijie Hou (Fujitsu) > <houzj.f...@fujitsu.com> wrote: > > > > > > Thanks for reporting the bug. I have fixed it and ran pgindent in V17 patch. > > I also adjusted few comments and fixed a typo. > > > > Thanks for the patch. Re-tested it, all scenarios seem to work well now. > > I see that this version has new header inclusion in conflict.c, due to > which I think "catalog/index.h" inclusion is now redundant. Please > recheck and remove if so. >
This is an extra include, so removed in the attached. Additionally, I have modified a few comments and commit message. > Also, there are few long lines in conflict.c (see line 408, 410). > I have left these as it is because pgindent doesn't complain about them. > Rest looks good. > Thanks for the review and testing. -- With Regards, Amit Kapila.
v18-0001-Log-the-conflicts-while-applying-changes-in-logi.patch
Description: Binary data
