Here are my review comments for the latest patchset v20240817-0001. No changes. No comments. v20240817-0002. No changes. No comments. v20240817-0003. See below. v20240817-0004. See below. v20240817-0005. No changes. No comments.
////// v20240817-0003 and 0004. (This is a repeat of the same comment as in previous reviews, but lots more functions seem affected now) IIUC, the LR code tries to follow function naming conventions (e.g. CamelCase/snake_case for exposed/static functions respectively), intended to make the code more readable. But, this only works if the conventions are followed. Now, patches 0003 and 0004 are shuffling more and more functions between modules while changing them from static to non-static (or vice versa). So, the function name conventions are being violated many times. IMO these functions ought to be renamed according to their new modifiers to avoid the confusion caused by ignoring the name conventions. ====== Kind Regards, Peter Smith. Fujitsu Australia
