On Mon, Aug 12, 2024 at 10:25:13AM -0400, Yogesh Sharma wrote: > Attaching a patch to add remaining cached and loaded stats as mentioned in > commit f68cd847fa40ead44a786b9c34aff9ccc048004b message. Existing TAP tests > were updated to handle new stats. This patch has been tested on HEAD using > "make check-world" after enabling injection points via > "--enable-injection-points".
Thanks a lot for the patch. I should have tackled that in f68cd847fa40 but I've just lacked a combination of time and energy while the original commit was already enough. The code indentation was a bit incorrect, and I think that we should also have tests to stress that the insertion of the new stats is correct. I have fixed the indentation, added some tests and improved a couple of surrounding descriptions while on it. I'm tempted to propose a separate improvement for the template of the fixed-numbered stats. We could do like pgstatfuncs.c where we use a macro to define the routines of the counters, and have one function for each counter incremented. That's a separate refactoring, so I'll propose that on a different thread. -- Michael
signature.asc
Description: PGP signature
