On Thu, 15 Aug 2024 at 19:50, Alexey Dvoichenkov <ale...@hyperplane.net> wrote: > I gave v3 another look. One tiny thing I've noticed is that you > removed ExecHashGetHashValue() but not its forward declaration in > include/executor/nodeHash.h
Fixed > I also reviewed the JIT code this time, it looks reasonable to > me. I've added names to some variables to make the IR easier to > read. (Probably best to squash it into your patch, if you want to > apply this.) Thanks. I've included that. I made another complete pass over this today and I noticed that there were a few cases where I wasn't properly setting resnull and resvalue to (Datum) 0. I'm happy with the patch now. I am aware nothing currently uses EEOP_HASHDATUM_SET_INITVAL, but I want to get moving with the Hash Aggregate usages of this code fairly quickly and I'd rather get the ExprState step code done now and not have to change it again. v4 patch attached. If nobody else wants to look at this then I'm planning on pushing it soon. David
v4-0001-Speed-up-Hash-Join-by-making-ExprStates-support-h.patch
Description: Binary data
