On Fri, 16 Aug 2024 at 23:48, Amul Sul <sula...@gmail.com> wrote: > The Assert(buffer != NULL) is placed after the buffer is accessed, > which could lead to a segmentation fault before the check is executed.
Yeah, that's not great. Technically the Assert does not add any value in terms of catching bugs in the code, but it's probably useful to keep it for code documentation purposes. A crash would occur even if the Assert wasn't there. > Attached a small patch to correct that. Pushed. David
