On Fri, Jul 26, 2024 at 01:22:24PM +0900, Yugo Nagata wrote: > I found the following in the release notes: > > Change file boundary handling of two WAL file name functions > (Kyotaro Horiguchi, Andres Freund, Bruce Momjian) > > The functions pg_walfile_name() and pg_walfile_name_offset() used to report > the previous > LSN segment number when the LSN was on a file segment boundary; it now > returns the LSN segment. > > It might be trivial, but, reading the associated commit message , I think it > would be more explicit > for users to rewrite the last statement to > > "it now returns the current LSN segment."
Agreed, applied patch attached. Sorry for the delay. -- Bruce Momjian <br...@momjian.us> https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.
diff --git a/doc/src/sgml/release-17.sgml b/doc/src/sgml/release-17.sgml index dfbf8a74cd4..8a1e51f10d6 100644 --- a/doc/src/sgml/release-17.sgml +++ b/doc/src/sgml/release-17.sgml @@ -176,7 +176,7 @@ Author: Bruce Momjian <br...@momjian.us> and <function>pg_walfile_name_offset()</function> used to report the previous <acronym>LSN</acronym> segment number when the <acronym>LSN</acronym> was on a file segment boundary; it now - returns the <acronym>LSN</acronym> segment. + returns the current <acronym>LSN</acronym> segment. </para> </listitem>