On 8/8/24 19:42, Robert Haas wrote: > On Thu, Aug 8, 2024 at 6:11 AM Peter Eisentraut <pe...@eisentraut.org> wrote: >> About the claim that it's already the de-facto standard. Maybe that is >> approximately true for "serious" installations. But AFAICT, the popular >> packagings don't enable checksums by default, so there is likely a >> significant middle tier between "just trying it out" and serious >> production use that don't have it turned on. > > +1. > >> I'm thinking pg_upgrade could have a mode where it adds the >> checksum during the upgrade as it copies the files (essentially a subset >> of pg_checksums). I think that would be useful for that middle tier of >> users who just want a good default experience. > > That would be very nice. >
Yeah, but it might also disable checksums on the new cluster, which would work for link mode too. So we'd probably want multiple modes, one to enable checksums during file copy, one to disable checksums, and one to just fail for incompatible clusters. -- Tomas Vondra
