On 05.08.24 17:28, Nathan Bossart wrote:
This looks pretty good to me. The only point that I think deserves more discussion is the return type. Does bytea make the most sense here? Or should we consider int/bigint?
The correct return type of a CRC operation in general is some kind of exact numerical type. Just pick the best one that fits the result. I don't think bytea is appropriate.