On Fri, Aug 2, 2024 at 7:43 AM Amul Sul <sula...@gmail.com> wrote: > Please consider the attached version for the review.
Thanks. I committed 0001-0003. The only thing that I changed was that in 0001, you forgot to pgindent, which actually mattered quite a bit, because astreamer is one character shorter than bbstreamer. Before we proceed with the rest of this patch series, I think we should fix up the comments for some of the astreamer files. Proposed patch for that attached; please review. I also noticed that cfbot was unhappy about this patch set: [10:37:55.075] pg_verifybackup.c:100:7: error: no previous extern declaration for non-static variable 'format' [-Werror,-Wmissing-variable-declarations] [10:37:55.075] char format = '\0'; /* p(lain)/t(ar) */ [10:37:55.075] ^ [10:37:55.075] pg_verifybackup.c:100:1: note: declare 'static' if the variable is not intended to be used outside of this translation unit [10:37:55.075] char format = '\0'; /* p(lain)/t(ar) */ [10:37:55.075] ^ [10:37:55.075] pg_verifybackup.c:101:23: error: no previous extern declaration for non-static variable 'compress_algorithm' [-Werror,-Wmissing-variable-declarations] [10:37:55.075] pg_compress_algorithm compress_algorithm = PG_COMPRESSION_NONE; [10:37:55.075] ^ [10:37:55.075] pg_verifybackup.c:101:1: note: declare 'static' if the variable is not intended to be used outside of this translation unit [10:37:55.075] pg_compress_algorithm compress_algorithm = PG_COMPRESSION_NONE; [10:37:55.075] ^ [10:37:55.075] 2 errors generated. Please fix and, after posting future versions of the patch set, try to remember to check http://cfbot.cputube.org/amul-sul.html -- Robert Haas EDB: http://www.enterprisedb.com
v6-0001-Improve-file-header-comments-for-astramer-code.patch
Description: Binary data
