On Tue, Jul 30, 2024 at 10:01:50PM -0500, Nathan Bossart wrote: > On Tue, Jul 30, 2024 at 07:43:08PM -0700, Andres Freund wrote: >> My point is that _xgetbv() is made available by -mavx512vpopcntdq -mavx512bw >> alone, without needing -mxsave: > > Oh, I see. I'll work on a patch to remove that compiler check, then...
As I started on this, I remembered why I needed it. The file pg_popcount_avx512_choose.c is compiled without the AVX-512 flags in order to avoid inadvertently issuing any AVX-512 instructions before determining we have support. If that's not a concern, we could still probably remove the XSAVE check. -- nathan