On Thu, Jul 25, 2024 at 11:16 PM Amit Langote <amitlangot...@gmail.com> wrote: > On Wed, Jul 24, 2024 at 3:25 PM jian he <jian.universal...@gmail.com> wrote: > > 2. domain over jsonb should fail just like domain over other types? > > RETURNING djs keep quotes DEFAULT '"11"' ON empty > > should fail as > > ERROR: could not coerce ON EMPTY expression (DEFAULT) to the RETURNING type > > DETAIL: value for domain djs violates check constraint "djs_check"" > > I think this should be fixed with the attached patch 0004.
It is fixed but with the patch 0003, not 0004. Also, the test cases in 0004, which is a patch to fix a problem with OMIT QUOTES being disregarded when RETURNING domain-over-jsonb, didn't test that problem. So I have updated the test case to use a domain over jsonb. -- Thanks, Amit Langote
0004-SQL-JSON-Respect-OMIT-QUOTES-when-RETURNING-domains-.patch
Description: Binary data
0005-SQL-JSON-Remove-useless-code-in-ExecInitJsonExpr.patch
Description: Binary data
0001-SQL-JSON-Some-fixes-to-JsonBehavior-expression-casti.patch
Description: Binary data
0003-SQL-JSON-Fix-handling-of-errors-coercing-JsonBehavio.patch
Description: Binary data
0002-SQL-JSON-Fix-casting-for-integer-EXISTS-columns-in-J.patch
Description: Binary data
