On Thu, Jul 18, 2024 at 02:11:13PM +0300, Nazir Bilal Yavuz wrote: > v4 is attached.
Removal of the PinBufferForBlock() comment about the "persistence = RELPERSISTENCE_PERMANENT" fallback started to feel like a loss. I looked for a way to re-add a comment about the fallback. https://coverage.postgresql.org/src/backend/storage/buffer/bufmgr.c.gcov.html shows no test coverage of that fallback, and I think the fallback is unreachable. Hence, I've removed the fallback in a separate commit. I've pushed that and your three patches. Thanks.
