On Tue, 9 Jul 2024 at 14:44, Tatsuo Ishii <is...@postgresql.org> wrote: > BTW, it seems these executor nodes (other than Materialize and Window > Aggregate node) use tuplestore for their own purpose. > > CTE Scan > Recursive Union > Table Function Scan > > I have already implemented that for CTE Scan. Do you think other two > nodes are worth to add the information?
Yes, I think so. I'd keep each as a separate patch so they can be considered independently. Doing all of them should hopefully ensure we strike the right balance of what code to put in explain.c and what code to put in tuplestore.c. I think the WindowAgg's tuplestore usage pattern might show that the API I picked isn't well suited when a tuplestore is cleared and refilled over and over. David
