On Fri, Jul 5, 2024 at 10:16 PM Erik Rijkers <e...@xs4all.nl> wrote: > Op 7/5/24 om 14:35 schreef Amit Langote: > > Hi Jian, > > > > Thanks for the reviews. > > > > [v3-0001-SQL-JSON-Various-improvements-to-SQL-JSON-query-f.patch] > i.e., from the patch for doc/src/sgml/func.sgml > > > Small changes: > > 4x: > 'a SQL' should be > 'an SQL' > ('a SQL' does never occur in the docs; it's always 'an SQL'; apperently > the 'sequel' pronunciation is out) > > 'some other type to which can be successfully coerced' > 'some other type to which it can be successfully coerced' > > > 'specifies the behavior behavior' > 'specifies the behavior' > > > In the following sentence: > > "By default, the result is returned as a value of type <type>jsonb</type>, > though the <literal>RETURNING</literal> clause can be used to return > the original <type>jsonb</type> value as some other type to which it > can be successfully coerced." > > it seems to me that this phrase is better removed: > "the original <type>jsonb</type> value as"
Thanks, I've addressed all these in the next patch I'll send. -- Thanks, Amit Langote