On Sun, Jul 7, 2024, at 13:28, Dean Rasheed wrote: > I've also tidied up a bit by replacing all instances of SHRT_MAX with > a new constant NUMERIC_WEIGHT_MAX, whose name more accurately > describes the limit, as used in various other overflow checks.
Having thought a bit more on this, I think we probably need a DEC_DIGITS sensitive definition of NUMERIC_WEIGHT_MAX, since per spec the max range for numeric is 0x20000 (131072) decimal digits. Therefore, I think perhaps what we want is: +#define NUMERIC_DSCALE_MIN 0 +#define NUMERIC_WEIGHT_MAX ((0x20000/DEC_DIGITS)-1) +#define NUMERIC_WEIGHT_MIN (-(NUMERIC_DSCALE_MAX+1)/DEC_DIGITS) Maybe also 0x20000 (131072) should be a defined constant. Regards, Joel
