On Sun, Jun 30, 2024 at 09:42:19PM +0000, fujii.y...@df.mitsubishielectric.co.jp wrote: > On Mon, Jun 24, 2024 at 6:09?PM Jelte Fennema-Nio <postg...@jeltef.nl> wrote: > > 4. Related to 3, I think it would be good to have some tests of > > PARTIAL_AGGREGATE that don't involve postgres_fdw at all. I also > > spotted some comments too that mention FDW, even though they apply to > > the "pure" PARTIAL_AGGREGATE code. > > 5. This comment now seems incorrect: > > - * Apply the agg's finalfn if one is provided, else return transValue. > > + * If the agg's finalfn is provided and PARTIAL_AGGREGATE keyword is > > + * not specified, apply the agg's finalfn. > > + * If PARTIAL_AGGREGATE keyword is specified and the transValue type > > + * is internal, apply the agg's serialfn. In this case the agg's > > + * serialfn must not be invalid. Otherwise return transValue. > > > > 6. These errors are not on purpose afaict (if they are a comment in > > the test would be good to explain why) > > > > +SELECT b, avg(a), max(a), count(*) FROM pagg_tab GROUP BY b ORDER BY 1; > > +ERROR: could not connect to server "loopback" > > +DETAIL: invalid connection option "partial_aggregate_support" > Fixed.
Is there a reason the documentation is no longer a part of this patch? Can I help you keep it current? -- Bruce Momjian <br...@momjian.us> https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.
