Hi Vignesh. Here are my comments for the latest patch v20240703-0001. ====== doc/src/sgml/func.sgml
nitpick - /lsn/LSN/ (all other doc pages I found use uppercase for this acronym) ====== src/backend/commands/sequence.c nitpick - /lsn/LSN/ ====== Please see attached nitpicks diff. ====== Kind Regards, Peter Smith. Fujitsu Australia
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml index d30864e..fb3f973 100644 --- a/doc/src/sgml/func.sgml +++ b/doc/src/sgml/func.sgml @@ -19521,7 +19521,7 @@ SELECT setval('myseq', 42, false); <lineannotation>Next <function>nextval</fu </para> <para> Returns information about the sequence. <literal>lsn</literal> is the - page lsn of the sequence, <literal>last_value</literal> is the most + page LSN of the sequence, <literal>last_value</literal> is the most recent value returned by <function>nextval</function> in the current session, <literal>log_cnt</literal> shows how many fetches remain before a new WAL record has to be written, and diff --git a/src/backend/commands/sequence.c b/src/backend/commands/sequence.c index d83dbd2..bff990a 100644 --- a/src/backend/commands/sequence.c +++ b/src/backend/commands/sequence.c @@ -1958,7 +1958,7 @@ pg_sequence_state(PG_FUNCTION_ARGS) UnlockReleaseBuffer(buf); relation_close(seqrel, NoLock); - /* Page lsn for the sequence */ + /* Page LSN for the sequence */ values[0] = LSNGetDatum(lsn); /* The value most recently returned by nextval in the current session */