On Sun, Jun 30, 2024 at 02:58:00PM -0400, Tom Lane wrote: > I wrote: > > In hopes of moving things along as we approach the v18 branch, > > I went ahead and pushed Kuroda-san's patches (with a bit of > > further editorialization). > > So b3f5ccebd promptly blew up on fairywren [1]: > > connection error: 'psql: error: unterminated quoted string in connection info > string' > while running 'psql -XAtq -d port=52984 host=C:/tools/nmsys64/tmp/hHg_pngw4z > dbname='regression\\\\"\\\\ > !"#$%&\\'()*+,-\\\\\\\\"\\\\\\\\\\\\' -f - -v ON_ERROR_STOP=1' at > C:/tools/nmsys64/home/pgrunner/bf/root/HEAD/pgsql/src/test/perl/PostgreSQL/Test/Cluster.pm > line 2124. > > This shows that the command-line arguments to psql are not getting > adequately quoted on that platform. AFAICS, we are relying on > IPC::Run::run to perform such quoting, and it seems to be > falling down here. I wonder what version of IPC::Run fairywren > is using.
It does look consistent with IPC::Run predating v20220807.0, hence lacking the https://github.com/toddr/IPC-Run/issues/142 fix. I wondered how this animal was passing 002_pg_upgrade.pl, but it seems the animal has run TAP suites only occasionally. Passes in the last week were TAP-free. > [1] > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=fairywren&dt=2024-06-30%2018%3A03%3A06
