> On 21 Jun 2024, at 10:36, Michael Paquier <mich...@paquier.xyz> wrote:
>
> On Fri, Jun 14, 2024 at 03:12:50PM -0500, Nathan Bossart wrote:
>> On Fri, Jun 14, 2024 at 12:06:36PM +0500, Andrey M. Borodin wrote:
>>> This patch looks good to me.
>>
>> Thanks for looking.
>
> While double-checking the whole, where I don't have much to say about
> 0001, I have fixed a few issues with the test presented upthread and
> stabilized it (CI and my stuff are both OK). I'd suggest to move it
> to test_misc/, because there is no clear category where to put it, and
> we have another test with injection points there for timeouts so the
> module dependency with EXTRA_INSTALL is already cleared.
>
> What do you think?
Thanks Michael!
All changes look good to me.
I just have one more concern: we do not wakeup() upon test end. I observed that
there might happen more autovacuums and start sleeping in injection point. In
every case I observed - these autovacuums quit gracefully. But is it guaranteed
that test will shut down node even if some of backends are waiting in injection
points?
Or, perhaps, should we always wakeup() after detaching? (in case when new point
run might happen)
Best regards, Andrey Borodin.
