I noticed that the "check" variable, which is used for "pg_upgrade
--check", is commented as follows:
bool check; /* true -> ask user for
permission to make
* changes */
This comment was first added when pg_upgrade was introduced (commit
c2e9b2f288), but I imagine it predates even that. I've attached a patch to
fix this. Barring objections, I'll probably commit this soon.
--
nathan
>From 379793a07dd98f65466452806756bfa0f6312bdf Mon Sep 17 00:00:00 2001
From: Nathan Bossart <nat...@postgresql.org>
Date: Tue, 18 Jun 2024 14:41:35 -0500
Subject: [PATCH v1 1/1] pg_upgrade: fix comment
---
src/bin/pg_upgrade/pg_upgrade.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/bin/pg_upgrade/pg_upgrade.h b/src/bin/pg_upgrade/pg_upgrade.h
index 92bcb693fb..8afe240bdf 100644
--- a/src/bin/pg_upgrade/pg_upgrade.h
+++ b/src/bin/pg_upgrade/pg_upgrade.h
@@ -321,8 +321,7 @@ typedef struct
*/
typedef struct
{
- bool check; /* true -> ask user for
permission to make
- * changes */
+ bool check; /* check clusters only, don't
change any data */
bool do_sync; /* flush changes to disk */
transferMode transfer_mode; /* copy files or link them? */
int jobs; /* number of
processes/threads to use */
--
2.39.3 (Apple Git-146)
