On Thu, Jun 13, 2024 at 06:56:20AM -0500, Justin Pryzby wrote: > On Thu, Jun 13, 2024 at 02:38:46PM +0300, Nazir Bilal Yavuz wrote: >>> I reintroduced the patch for ccache/windows -- v4.10 supports PCH, which >>> can make the builds 2x faster. >> >> I applied 0001 and 0002 to see ccache support on Windows but the build >> step failed with: 'ccache: error: No stats log has been configured'. >> Perhaps you forgot to add 'CCACHE_STATSLOG: $CCACHE_DIR.stats.log' to >> 0002? > > Something like that - I put the line back. I don't know if statslog > should be included in the patch, but it's useful for demonstrating that > it's working. > > ccache should be installed in the image rather than re-installed on each > invocation.
Getting a 90s -> 30s improvement is nice. With such numbers, 0002 is worth considering first. + ninja -C build |tee build.txt In 0001, how OK is it to rely on the existence of tee for the VS2019 environments? The base images include it, meaning that it is OK? - REM choco install -y --no-progress ... I'd rather keep this line in 0002, as a matter of documentation. + set CC=c:\ProgramData\chocolatey\lib\ccache\tools\ccache-4.10-windows-x86_64\ccache.exe cl.exe As of https://docs.mesa3d.org/meson.html#compiler-specification, using CC is supported by meson (didn't know that), but shouldn't this be set in the "env:" part of the VS2019 task in .cirrus.tasks.yml? -- Michael
signature.asc
Description: PGP signature
