On Wed, Jun 5, 2024 at 5:34 AM David Rowley <dgrowle...@gmail.com> wrote: > > On Sun, 2 Jun 2024 at 10:08, James Coleman <jtc...@gmail.com> wrote: > > See attached for a small patch fixing some typos and grammatical > > errors in a couple of comments. > > Thanks. I pushed this after messing with the comments a bit more.
Thanks! > > Side note: It's not clear to me what "Vars of higher levels don't > > matter here" means in this context (or how that claim is justified), > > but I haven't changed that part of the comment opting to simply > > resolve the clear mistakes in the wording here. > > It just means Vars with varlevelsup >= 2 don't matter. It only cares > about Vars with varlevelsup==1, i.e. Vars of the sub-query's direct > parent. Yes, I understood the content, but I didn't see any justification provided, which is what I'd hope for in a comment like this (why not simply what). Anyway, thanks again for reviewing and committing. James Coleman
