On Thu, May 16, 2024 at 10:39:18AM +0800, jian he wrote: > On Thu, May 9, 2024 at 12:04 PM Bruce Momjian <br...@momjian.us> wrote: > > > > I have committed the first draft of the PG 17 release notes; you can > > see the results here: > > > > https://momjian.us/pgsql_docs/release-17.html > > > > >> Add local I/O block read/write timing statistics columns of > >> pg_stat_statement (Nazir Bilal Yavuz) > >> The new columns are "local_blk_read_time" and "local_blk_write_time". > here, "pg_stat_statement" should be "pg_stat_statements"?
Agreed. > >> Add optional fourth parameter to pg_stat_statements_reset() to allow for > >> the resetting of only min/max statistics (Andrei Zubkov) > >> This parameter defaults to "false". > here, "parameter", should be "argument"? > > maybe > >> Add optional fourth boolean argument (minmax_only) to > >> pg_stat_statements_reset() to allow for the resetting of only min/max > >> statistics (Andrei Zubkov) > >> This argument defaults to "false". Sure. > ---------------------------------------------------------------- > in section: E.1.2. Migration to Version 17 > > >> Rename I/O block read/write timing statistics columns of pg_stat_statement > >> (Nazir Bilal Yavuz) > >> This renames "blk_read_time" to "shared_blk_read_time", and > >> "blk_write_time" to "shared_blk_write_time". > > "pg_stat_statement" should be "pg_stat_statements"? Yes, fixed. > also, we only mentioned, pg_stat_statements some columns name changed > in "E.1.2. Migration to Version 17" > but if you look at the release note pg_stat_statements section, > we added a bunch of columns, which are far more incompatibile than > just colunm name changes. > > not sure we need add these in section "E.1.2. Migration to Version 17" Well, new columns don't cause breakage like renamed columns, which is why I only put renames/removed columns in the migration section. Also, thanks everyone for the release notes feedback. In some cases I made a mistake, and in some cases I misjudged the item. -- Bruce Momjian <br...@momjian.us> https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.
