Hi, On 2024-04-18 10:54:18 +0200, Christoph Berg wrote: > Re: Andres Freund > > > This commit broke VPATH builds when the original source directory > > > contains symlinks. > > Argh, this is missing spaces around the '=', leading to the branch always > > being entered. > > Glad I found at least something :)
Yep :). I pushed a fix to that now. > I've been using this directory layout for years, apparently so far > I've always only used non-VPATH builds or dpkg-buildpackage, which > probably canonicalizes the path before building, given it works. I wonder if perhaps find's behaviour might have changed at some point? > Since no one else has been complaining, it might not be worth fixing. I'm personally not excited about working on fixing this, but if somebody else wants to spend the cycles to make this work reliably... It's certainly interesting that we have some code worrying about symlinks in configure.ac: # prepare build tree if outside source tree # Note 1: test -ef might not exist, but it's more reliable than `pwd`. # Note 2: /bin/pwd might be better than shell's built-in at getting # a symlink-free name. But we only use this to determine if we're doing a vpath build, not as the path passed to prep_buildtree... Greetings, Andres Freund
