On Tue, Apr 23, 2024 at 11:03:40PM -0400, Tom Lane wrote: > Hah. Seems like the comment for isall needs to explain that it > exists for this purpose, so we don't make this mistake again.
How about something like the attached? -- Michael
diff --git a/src/include/nodes/parsenodes.h b/src/include/nodes/parsenodes.h index c5f34efe27..512b0ef33f 100644 --- a/src/include/nodes/parsenodes.h +++ b/src/include/nodes/parsenodes.h @@ -4070,7 +4070,10 @@ typedef struct DeallocateStmt NodeTag type; /* The name of the plan to remove, NULL if DEALLOCATE ALL */ char *name pg_node_attr(query_jumble_ignore); - /* true if DEALLOCATE ALL */ + /* + * True if DEALLOCATE ALL, required to make the difference between ALL + * and a named DEALLOCATE in query jumbling. + */ bool isall; /* token location, or -1 if unknown */ ParseLoc location pg_node_attr(query_jumble_location);
signature.asc
Description: PGP signature
