On Fri, Apr 19, 2024 at 6:09 AM Zhijie Hou (Fujitsu) <houzj.f...@fujitsu.com> wrote: > > Here is V2 patch which includes the changes for CREATE SUBSCRIPTION as > suggested. Since we don't connect pub to alter slot when (create_slot=false) > anymore, the restriction that disallows failover=true when connect=false is > also removed.
Thanks for the patch. I feel getSubscription() also needs to get 'subfailover' option independent of dopt->binary_upgrade i.e. it needs similar changes as that of dumpSubscription(). I tested pg_dump, currently it is not dumping failover parameter for failover-enabled subscriptions, perhaps due to the same bug. Create-sub and Alter-sub changes look good and work well. thanks Shveta
