On Thu, Apr 11, 2024 at 12:20:55AM +0300, Heikki Linnakangas wrote: > To move this forward, here's a patch to switch to a pairing heap. In my very > quick testing, with the performance test cases posted earlier in this thread > [1] [2], I'm seeing no meaningful performance difference between this and > what's in master currently.
Reading through the patch, that's a nice cleanup. It cuts quite some code. +++ b/src/include/replication/reorderbuffer.h @@ -12,6 +12,7 @@ #include "access/htup_details.h" #include "lib/binaryheap.h" #include "lib/ilist.h" +#include "lib/pairingheap.h" I'm slightly annoyed by the extra amount of information that gets added to reorderbuffer.h for stuff that's only local to reorderbuffer.c, but that's not something new in this area, so.. -- Michael
signature.asc
Description: PGP signature
