On Thu, Jun 28, 2018 at 12:29 PM, Michael Paquier <mich...@paquier.xyz> wrote: > On Thu, Jun 28, 2018 at 11:51:20AM +0900, Masahiko Sawada wrote: >> A use case I imagined is for investigations for example. I mean that >> when replication collision occurs on subscriber there is no way to see >> what replicated data is conflicting (perhaps error log helps it but is >> not detailed) and there is no way to advance a replication origin in >> order to exactly skip to apply conflicting data. By creating a new >> logical slot with a different output plugin at the same LSN, we can >> see what data a replication slot will decode (and send) and those LSNs >> as well. This function will help for that purpose. > > Hm. Shouldn't the original slot copied be owned by the process doing > the copy with ReplicationSlotAcquire?
Right, it should do and release it before creating new one. > There could be some cases where > copying a physical slot also makes sense. I've thought that but I didn't find concrete use case. That's why I started with only logical slot. Attached v2 patch. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
v2-0001-Copy-logical-replication-slot.patch
Description: Binary data
