> On 4 Apr 2024, at 08:19, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Over at [1] we have a complaint of postgres_fdw failing with > a remote-server error > >> ERROR: invalid value for parameter "TimeZone": "UTC" > > I am not quite clear on how broken an installation needs to be to > reject "UTC" as a time zone setting, except that the breakage cannot > be subtle. However, I notice that our code in pgtz.c and other > places treats "GMT" as a hard-wired special case ... but not "UTC". > I wonder if we ought to modify those places to force "UTC" down the > same hard-wired paths. If we acted like that, this would have worked > no matter how misconfigured the installation was.
+1. It makes little sense to support GMT like that but not UTC. > An alternative answer could be to change postgres_fdw to send "GMT" > not "UTC". That's ugly from a standards-compliance viewpoint, but > it would fix this problem even with a non-updated remote server, > and I think postgres_fdw is generally intended to work with even > very old remote servers. There is always a risk in accomodating broken installations that it might hide other subtle bugs, but off the cuff that risk seems quite low in this case. -- Daniel Gustafsson