> On 25 Mar 2024, at 19:48, Andres Freund <and...@anarazel.de> wrote:
> I don't think it's that, but that the freebsd task tests the installcheck > equivalent in meson. I haven't checked what your patch is doing, but perhaps > the issue is that it's seeing global objects concurrently created by another > test? Sorry, I had a look when Peter replied a while back but forgot to update this thread. The reason for the failure is that when running multiple pg_regress in parallel against a single instance it is impossible to avoid global object pollution from other tests concurrently executing. Since pg_regress has no idea about the contents of the tests it also cannot apply any smarts in filtering out such objects. The CI failures comes from the contrib tests which run in parallel. The only option is to make the check opt-in via a command-line parameter for use it in the main regress tests, and not use it for the contrib tests. The attached v7 does that and passes CI, but I wonder if it's worth it all with that restriction? The 0001 cleanup patch is still relevant (and was found by using this feature) though but that might be all for this thread. -- Daniel Gustafsson
v7-0002-pg_regress-Detect-global-objects-left-over-after-.patch
Description: Binary data
v7-0001-Drop-global-objects-after-completed-test.patch
Description: Binary data
