On Tue, Mar 19, 2024 at 5:18 PM Hayato Kuroda (Fujitsu) <kuroda.hay...@fujitsu.com> wrote: > > Thanks for giving comments! > > > This behavior makes sense to me. But do we want to handle the case of > > using environment variables too? > > Yeah, v5 does not consider which libpq parameters are specified by environment > variables. Such a variable should be used when the dbname is not expressly > written > in the connection string. > Such a path was added in the v6 patch. If the dbname is not determined after > parsing the connection string, we call PQconndefaults() to get settings from > environment variables and service files [1], then start to search dbname > again. >
The functionality implemented by the patch looks good to me. I have made minor modifications in the function names, error handling, comments, and doc updates in the attached patch. Let me know what you think of the attached. -- With Regards, Amit Kapila.
pg_basebackup-write-dbname.v0007.patch
Description: Binary data
