On Wed, Mar 20, 2024 at 12:49 AM Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> wrote: > > > Following are some open points: > > 1. Where to do inactive_timeout invalidation exactly if not the checkpointer. >
I have suggested to do it at the time of CheckpointReplicationSlots() and Bertrand suggested to do it whenever we resume using the slot. I think we should follow both the suggestions. > 2. Where to do XID age invalidation exactly if not the checkpointer. > 3. How to go about recomputing XID horizons based on max_slot_xid_age. > Does the slot's horizon's need to be adjusted in ComputeXidHorizons()? > I suggest postponing the patch for xid based invalidation for a later discussion. > 4. New invalidation mechanisms interaction with slot sync feature. > Yeah, this is important. My initial thoughts are that synced slots shouldn't be invalidated on the standby due to timeout. > 5. Review comments on 0001 from Bertrand. > > Please see the attached v12 patches. > Thanks for quickly updating the patches. -- With Regards, Amit Kapila.
