On Wed, Mar 13, 2024 at 02:24:32PM +0100, Peter Eisentraut wrote: > On 08.03.24 06:50, Michael Paquier wrote: >> This is usually taken care of by committers or updated automatically. > > both fixed
Looks mostly fine, thanks for the new version. -EventTriggerSupportsObjectClass(ObjectClass objclass) +EventTriggerSupportsObject(const ObjectAddress *object) The shortcut introduced here is interesting, but it is inconsistent. HEAD treats OCLASS_SUBSCRIPTION as something supported by event triggers, but as pg_subscription is a shared catalog it would be discarded with your change. Subscriptions are marked as supported in the event trigger table: https://www.postgresql.org/docs/devel/event-trigger-matrix.html -- Michael
signature.asc
Description: PGP signature
