On Monday, March 4, 2024 5:52 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Mon, Mar 4, 2024 at 9:35 AM Peter Smith <smithpb2...@gmail.com> > wrote: > > > > OK, if the code will remain as-is wouldn't it be better to anyway > > change the function name to indicate what it really does? > > > > e.g. NeedToWaitForWal --> NeedToWaitForWalFlushOrStandbys > > > > This seems too long. I would prefer the current name NeedToWaitForWal as > waiting for WAL means waiting to flush the WAL and waiting to replicate it to > standby. On similar lines, the variable name standby_slot_oldest_flush_lsn > looks > too long. How about ss_oldest_flush_lsn (where ss indicates standy_slots)? > > Apart from this, I have made minor modifications in the attached.
Thanks, I have merged it. Attach the V105 patch set which addressed Peter, Amit and Bertrand's comments. This version also includes the following changes: * We found a string matching issue for query_until() and fixed it. * Removed one un-used parameter from NeedToWaitForStandbys. * Disable the sub before testing the pg_logical_slot_get_changes in 040.pl, this is to prevent This test from catching the warning from another walsender. * Ran pgindent. Best Regards, Hou zj
v105-0001-Allow-logical-walsenders-to-wait-for-the-physic.patch
Description: v105-0001-Allow-logical-walsenders-to-wait-for-the-physic.patch
v105-0002-Document-the-steps-to-check-if-the-standby-is-r.patch
Description: v105-0002-Document-the-steps-to-check-if-the-standby-is-r.patch
